Skip to content

Correct deletion cron env variable #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct deletion cron env variable #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Manage Lambda Logs Generated By SST

This is a fork of Allan Helton's project [here](https://github.com/allenheltondev/serverless-lambda-log-management) which was developed for use with AWS SAM. [SST](https://sst.dev) is my personal favourite means of deploying serverless applications so I've taken what Allan did and converted it to use SST and TypeScript.
This is a fork of Allen Helton's project [here](https://github.com/allenheltondev/serverless-lambda-log-management) which was developed for use with AWS SAM. [SST](https://sst.dev) is my personal favourite means of deploying serverless applications so I've taken what Allen did and converted it to use SST and TypeScript.

## In This Stack

Expand Down Expand Up @@ -38,7 +38,7 @@ This project uses the [AWS v3 SDK](https://docs.aws.amazon.com/AWSJavaScriptSDK/
The lambda functions are running *nodejs18.x* and are executed on the *arm64 architecture* aka [AWS Graviton2 processor](https://aws.amazon.com/blogs/aws/aws-lambda-functions-powered-by-aws-graviton2-processor-run-your-functions-on-arm-and-get-up-to-34-better-price-performance/).

## Contact
You can show your support for the original project by following Allan on [Twitter][1] or connecting with him on [LinkedIn][3].
You can show your support for the original project by following Allen on [Twitter][1] or connecting with him on [LinkedIn][3].
I'm on [Twitter](https://www.twitter.com/rcoundon)
too if you have any questions on this implementation, or log an issue on Github.

Expand Down
4 changes: 2 additions & 2 deletions stacks/log-management-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ export function logManagementStack(ctx: sst.StackContext) {
environment,
});

if (process.env.LOG_GROUP_RETENTION_CRON && !ctx.app.local) {
if (process.env.LOG_GROUP_DELETE_CRON && !ctx.app.local) {
new sst.Cron(ctx.stack, 'log-group-deletion-cron', {
job: deleteUnusedLogsFunction,
schedule: process.env.LOG_GROUP_RETENTION_CRON,
schedule: process.env.LOG_GROUP_DELETE_CRON,
});
}

Expand Down