Update index.js#2
Open
jjborie wants to merge 1 commit into
Open
Conversation
Hi,
If you pass a component as parameter to textComponent, I am receiving a warning:
Warning: Failed prop type: Invalid prop `textComponent` of type `object` supplied to `PhoneInput`, expected `function`.
```
<PhoneInput
textComponent={TextInput}
/>
```
The PropTypes don't look to be correct.
|
Hi,
On February 4th npm will add me as an adopter of the package, and I will be
able to publish new versions.
…On Fri, Jan 29, 2021, 3:46 PM jjborie ***@***.***> wrote:
Hi,
If you pass a component as parameter to textComponent, I am receiving a
warning:
Warning: Failed prop type: Invalid prop textComponent of type object
supplied to PhoneInput, expected function.
<PhoneInput
textComponent={TextInput}
/>
The PropTypes don't look to be correct.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Update index.js
File Changes
- *M* lib/index.js
<https://github.com/ravi-poonia/react-native-phone-input/pull/2/files#diff-92bbac9a308cd5fcf9db165841f2d90ce981baddcb2b1e26cfff170929af3bd1>
(2)
Patch Links:
- https://github.com/ravi-poonia/react-native-phone-input/pull/2.patch
- https://github.com/ravi-poonia/react-native-phone-input/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXGCEUB23XLTZ4PUWIPGRTS4MUCZANCNFSM4WZSWD7Q>
.
|
Author
|
Hi, any news? thanks |
|
I have adopted the project, published v1.0.0, and converted the source to typescript. Let me know if there is anything I can do to improve the change request process. Please submit new pull requests as the package as been moved to https://github.com/rili-live/react-native-phone-input |
|
@zizzle6717 can you enable issues there? |
|
Done. If you would like to be a maintainer, please let me know. |
Author
|
@zizzle6717 happy to help, you can add me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
If you pass a component as parameter to textComponent, I am receiving a warning:
Warning: Failed prop type: Invalid prop
textComponentof typeobjectsupplied toPhoneInput, expectedfunction.The PropTypes don't look to be correct.