Skip to content

fix(docs): correct typos found during code review #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcelpetrick wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(docs): correct typos found during code review #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6271f
fix(docs): correct typos found during code review
marcelpetrick Dec 3, 2025
11b8a77
Reverted two changes to files from dependencies.
marcelpetrick Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions debian/changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,10 @@ rpi-imager (1.8.2) unstable; urgency=medium
* Home: Device filtering reworked to download OS list eagerly
* OS List: Fixed 'Recommended' tag annotation
* i18n: Added zh-TW Traditional Chinese translation
* i18n: Updated Korean, German, Ukranian, translations
* i18n: Updated Korean, German, Ukrainian, translations
Copy link
Collaborator

@tdewey-rpi tdewey-rpi Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the review - changing previous changelog entries is not something I generally countenance: it feels a little too much like trying to revise history, even if the history you're revising is careless typos.

* build: Linux: Fix libdrm dependency requirement on non-embedded
build.
* Commmon: Disable QML caching entirely
* Common: Disable QML caching entirely
* OS customisation: Allow use if only cloudinit payload available
* OS customisation: Allow empty PSK for 'Open' WiFi networks.
* OS List: Use ImageList v4 URL
Expand All @@ -241,7 +241,7 @@ rpi-imager (1.8.0) unstable; urgency=medium
* i18n: Adds Spanish/Ukrainian translations
* i18n: Updates French, Catalan, Italian, German, Spanish, Russian,
Japanese translations
* i18n: Use en_US as refernce string, and make en_GB a translation
* i18n: Use en_US as reference string, and make en_GB a translation
* Workaround for ArchLinux's lsblk labeling internal SD card readers
(mmcblk0) as non-removable storage.
* Allow drag-dropping image files to Imager.
Expand Down Expand Up @@ -295,7 +295,7 @@ rpi-imager (1.7.3) unstable; urgency=medium

rpi-imager (1.7.2) unstable; urgency=medium

* Remove overscan/piwiz supression advanced options
* Remove overscan/piwiz suppression advanced options
* gz/xz/zstd custom images: pad if image size is not dividable by 512 byte
* Store saved wifi password hashed
* Make buttons blue on keyboard navigation
Expand Down
2 changes: 1 addition & 1 deletion doc/json-schema/os-list-schema.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/devicewrapperfatpartition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ void DeviceWrapperFatPartition::setFAT32(uint32_t cluster, uint32_t value)
/* Modify all FATs (usually 2) */
for (auto fatStart : std::as_const(_fatStartOffset))
{
/* Spec (p. 16) mentions we must preserve high 4 bits of FAT32 FAT entry when modifiying */
/* Spec (p. 16) mentions we must preserve high 4 bits of FAT32 FAT entry when modifying */
seek(fatStart + cluster * 4);
read( (char *) &prev_value, 4);
reserved_bits = prev_value & 0xF0000000;
Expand Down
2 changes: 1 addition & 1 deletion src/downloadthread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class DownloadThread : public QThread
/*
* Cancel download
*
* Async function. Returns immedeately, but can take a second before download actually stops
* Async function. Returns immediately, but can take a second before download actually stops
*/
virtual void cancelDownload();

Expand Down
2 changes: 1 addition & 1 deletion src/drivelistmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ DriveListModel::DriveListModel(QObject *parent)
{childDevicesRole, "childDevices"}
};

// Enumerate drives in seperate thread, but process results in UI thread
// Enumerate drives in separate thread, but process results in UI thread
connect(&_thread, SIGNAL(newDriveList(std::vector<Drivelist::DeviceDescriptor>)), SLOT(processDriveList(std::vector<Drivelist::DeviceDescriptor>)));

// Forward performance event signal
Expand Down
2 changes: 1 addition & 1 deletion src/imagewriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,7 +1523,7 @@ void ImageWriter::beginOSListFetch() {
request.setAttribute(QNetworkRequest::RedirectPolicyAttribute,
QNetworkRequest::NoLessSafeRedirectPolicy);
request.setMaximumRedirectsAllowed(3);
// This will set up a chain of requests that culiminate in the eventual fetch and assembly of
// This will set up a chain of requests that culminate in the eventual fetch and assembly of
// a complete cached OS list.
QNetworkReply *reply = _networkManager.get(request);
_networkRequestStartTimes[reply] = QDateTime::currentMSecsSinceEpoch();
Expand Down