Skip to content

Register EmpiricalCovariance benchmark algorithm - #8120

Merged
rapids-bot[bot] merged 4 commits into
rapidsai:mainfrom
csadorf:empirical-covariance-benchmarks
Jul 31, 2026
Merged

Register EmpiricalCovariance benchmark algorithm#8120
rapids-bot[bot] merged 4 commits into
rapidsai:mainfrom
csadorf:empirical-covariance-benchmarks

Conversation

@csadorf

@csadorf csadorf commented May 15, 2026

Copy link
Copy Markdown
Contributor

Adds EmpiricalCovariance to the benchmark algorithm registry so it can be used by cuML benchmark tooling.

Part of #8117

@csadorf
csadorf requested a review from a team as a code owner May 15, 2026 20:44
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 15, 2026
@csadorf
csadorf requested a review from divyegala May 15, 2026 20:44
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 15, 2026
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7a19d13b-d8df-4cef-9a5f-396c3c181871

📥 Commits

Reviewing files that changed from the base of the PR and between ab98e80 and 69e3cb9.

📒 Files selected for processing (1)
  • python/cuml/cuml/benchmark/algorithms.py

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added benchmarking support for the EmpiricalCovariance algorithm.

Walkthrough

This PR adds benchmarking support for EmpiricalCovariance. The changes import sklearn and cuML covariance modules, conditionally initialize the cuML implementation when available, and register an algorithm pair in the benchmark framework that maps sklearn's implementation to cuML's with accepts_labels=False.

Changes

EmpiricalCovariance benchmarking

Layer / File(s) Summary
Module imports for covariance algorithms
python/cuml/cuml/benchmark/algorithms.py
Adds imports for sklearn.covariance and conditionally for cuml.covariance to enable algorithm registration.
Algorithm definition and registration
python/cuml/cuml/benchmark/algorithms.py
Conditionally initializes cuml_EmpiricalCovariance based on cuML availability and registers a new AlgorithmPair that pairs sklearn.covariance.EmpiricalCovariance with its cuML equivalent.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Register EmpiricalCovariance benchmark algorithm' directly and clearly summarizes the main change: adding EmpiricalCovariance to the benchmark algorithm registry.
Description check ✅ Passed The description is directly related to the changeset, explaining that EmpiricalCovariance is being added to the benchmark algorithm registry and referencing the associated issue.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf
csadorf force-pushed the empirical-covariance-benchmarks branch from 69e3cb9 to 9bdd8aa Compare July 7, 2026 19:54

@viclafargue viclafargue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we also add it to the benchmark config?

@copy-pr-bot

copy-pr-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@csadorf

This comment has been minimized.

@csadorf

This comment has been minimized.

@csadorf

csadorf commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 449ece6 into rapidsai:main Jul 31, 2026
250 of 256 checks passed
@csadorf
csadorf deleted the empirical-covariance-benchmarks branch July 31, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants