[DO NOT MERGE] wheels: build CUDA 13 wheels with latest CTK (13.3.0)#487
[DO NOT MERGE] wheels: build CUDA 13 wheels with latest CTK (13.3.0)#487jameslamb wants to merge 8 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Builds (conda and wheels) are failing like this: Believe this was broken by NVIDIA/raft#3052 We'll need new update: merged a small PR to |
|
/ok to test |
| - wheel-tests-pylibwholegraph-nightly | ||
| - wheel-build-cugraph-pyg | ||
| - wheel-tests-cugraph-pyg | ||
| - wheel-tests-cugraph-pyg-nightly |
There was a problem hiding this comment.
TODO before merging: remove these
Just added to test that the nightly matrices would work too.
|
/ok to test |
| wheel-build-cugraph-pyg: | ||
| secrets: inherit # zizmor: ignore[secrets-inherit] | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@main | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@newest-ctk |
There was a problem hiding this comment.
Just picking a random place on the diff so this conversation can be threaded and eventually resolved... still seeing the issues from #487 (comment), so maybe the entire chain of packages picking up new builds for the RAFT ABI break didn't make it up yet.
Just pushed another commit, trying again. If that fails, I'll go look more closely.
Greptile SummaryThis PR is part of a RAPIDS-wide initiative to build wheels against CUDA 13.3.0 (CTK 13.3). It switches wheel-build jobs to a temporary
Confidence Score: 4/5Infrastructure-only CI/dependency change; no production code is modified. The main risk is that adding nightly jobs as required PR checks could block unrelated PRs if CUDA 13 tests are not yet stable. All changes are CI scripts and dependency declarations. The unconditional torch download/test path is a deliberate tightening of assumptions that the author has justified. One comment is incomplete, and the nightly jobs becoming required checks warrants a second look before final merge. .github/workflows/pr.yaml — the two new nightly jobs added to pr-builder deserve confirmation that they won't gate unrelated PRs on potentially unstable CUDA 13.3 runners. dependencies.yaml — the incomplete comment around the cuda: "13.*" cuda-toolkit entry. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI Trigger] --> B[wheel-build jobs\n@newest-ctk branch]
B --> C[wheel-build-libwholegraph]
B --> D[wheel-build-cugraph-pyg]
C --> E[wheel-build-pylibwholegraph]
E --> F[wheel-tests-pylibwholegraph\nstable matrix]
E --> G[wheel-tests-pylibwholegraph-nightly\nnightly matrix - NEW]
E --> H[wheel-tests-cugraph-pyg\nstable matrix]
D --> H
E --> I[wheel-tests-cugraph-pyg-nightly\nnightly matrix - NEW]
D --> I
F --> J[pr-builder\nrequired gate]
G --> J
H --> J
I --> J
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[CI Trigger] --> B[wheel-build jobs\n@newest-ctk branch]
B --> C[wheel-build-libwholegraph]
B --> D[wheel-build-cugraph-pyg]
C --> E[wheel-build-pylibwholegraph]
E --> F[wheel-tests-pylibwholegraph\nstable matrix]
E --> G[wheel-tests-pylibwholegraph-nightly\nnightly matrix - NEW]
E --> H[wheel-tests-cugraph-pyg\nstable matrix]
D --> H
E --> I[wheel-tests-cugraph-pyg-nightly\nnightly matrix - NEW]
D --> I
F --> J[pr-builder\nrequired gate]
G --> J
H --> J
I --> J
Reviews (1): Last reviewed commit: "empty commit to re-trigger CI" | Re-trigger Greptile |
| # 'torch' uses '==' pins for its cuda-toolkit dependency and only supports certain versions | ||
| # | ||
| # ... allowing this to float allows us |
There was a problem hiding this comment.
The comment is cut off mid-sentence, leaving the rationale unexplained.
| # 'torch' uses '==' pins for its cuda-toolkit dependency and only supports certain versions | |
| # | |
| # ... allowing this to float allows us | |
| # 'torch' uses '==' pins for its cuda-toolkit dependency and only supports certain versions, | |
| # so an exact pin here would conflict. Allowing this to float lets the solver pick a | |
| # compatible CTK version (13.1+) without fighting torch's own constraints. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| - wheel-build-libwholegraph | ||
| - wheel-build-pylibwholegraph | ||
| - wheel-tests-pylibwholegraph | ||
| - wheel-tests-pylibwholegraph-nightly | ||
| - wheel-build-cugraph-pyg | ||
| - wheel-tests-cugraph-pyg | ||
| - wheel-tests-cugraph-pyg-nightly | ||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main |
There was a problem hiding this comment.
wheel-tests-pylibwholegraph-nightly and wheel-tests-cugraph-pyg-nightly are now required checks in pr-builder. If nightly matrix tests against CUDA 13.3 are flaky or not yet stable, every PR would be blocked. This looks intentional here, but confirm this remains the right gating strategy when rebasing onto the final shape of the newest-ctk branch changes.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributes to rapidsai/build-planning#268
Part of a RAPIDS-wide initiative to build wheels using v13.3.0 of the CUDA Toolkit, and to generally get RAPIDS back to the pattern of always building against its latest supported CTK.
Notes for Reviewers
The workflow-branch changes here will be reverted before merging.