feat(#64): add batch ingest API with per-item outcomes#68
Merged
Conversation
Add MemoryStore::batch_ingest() for efficient multi-memory ingestion with conflict-aware and force policies. Returns per-item results (Added/Conflicts/Error) with deterministic index mapping. - IngestPolicy enum (ConflictAware, Force) - BatchIngestItemResult with per-item outcome tracking - Input validation (empty, whitespace, oversized content) - Comprehensive test suite (9 tests: unit + integration) - Consistency guarantees documented (independent processing, no atomics) Fixes #64
- Replace new_with_db with from_db (HEAD naming convention) - Remove .unwrap() from from_db calls (returns Self, not Result) - Update all batch test and main.rs calls to use correct API
The test was using semantically similar but different text ('Alice works at Microsoft'
vs 'Alice is employed at Microsoft'), expecting mock embeddings to detect semantic
similarity. However, mock embeddings use hash-based deterministic generation which
produces dissimilar vectors for different text, regardless of semantic similarity.
Fixed by changing the test to use exact duplicate text, which mock embeddings can
reliably detect as conflicts. This aligns with existing batch_tests behavior and
is a valid test of conflict detection with mock embeddings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
MemoryStore::batch_ingest()for efficient multi-memory ingestion with conflict-aware and force policies. Returns per-item results (Added/Conflicts/Error) with deterministic index mapping.Changes
IngestPolicyenum (ConflictAware, Force)BatchIngestItemResultwith per-item outcome trackingQuality
Fixes #64
Part of #61