Use Artifact Registry images #46
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Container Registry is deprecated [1]. [1]: https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
…egistry The Container Registry is deprecated [1]. [1]: https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
This brings consistency with image names from Google's Artifact Registry, and is an opportunity to use more inclusive language.
|
Spend a lot of time on this one and came to the same conclusion, all images pointing to google registry that are using examples hosted here : https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/quickstarts/guestbook/php-redis/guestbook.php A quick fix is to search and replace (master -> leader & slaver -> follower) on rancher/fleet-examples deployments and services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This points all Docker images to Google's Artifact Registry, following deprecation of their Container Registry.
By the same token, for consistency with newly used image names as well as inclusiveness, this replaces master/slave terminology with leader/follower.
Follow-up to #45.