Skip to content

[k6] More tests for vai and UI testing #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[k6] More tests for vai and UI testing #98

wants to merge 7 commits into from
+566 −2

Conversation

@MSpencer87
Copy link
Contributor

@MSpencer87 MSpencer87 commented Jul 17, 2025

No description provided.

@MSpencer87 MSpencer87 force-pushed the more-tests branch 2 times, most recently from 0b3be40 to fd19535 Compare November 6, 2025 16:47
@MSpencer87 MSpencer87 marked this pull request as ready for review November 6, 2025 17:19
git-ival
git-ival requested changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@git-ival git-ival left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I have some thoughts mostly around the code structure. I think we should try and make the functions in the utils as generic as possible.

To that end, maybe we have the metadata and data be separate parameters to our util functions for API requests like these (see the secrets-oriented functions for example). That way you can pass in any valid metadata + data and have it work™️. I think we would also want to default to the currently hardcoded defaults if they are not passed in*

@git-ival
Copy link
Contributor

git-ival commented Nov 14, 2025

Nitpick: can we rename the functions in generic_utils.js to use the singular tense (since they don't create multiple secrets)?

It would also be good to return the res object in case future tests might benefit from having access to the full response data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-ival git-ival git-ival requested changes

@rancher-max rancher-max Awaiting requested review from rancher-max

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

team/bullseye-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MSpencer87 @git-ival