Add RTBs test #113
Open
Add RTBs test #113
+875
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-ival
force-pushed
the
add-rtbs-test
branch
3 times, most recently
from
407fe8e to
a1710fa
Compare
* wip resource churn * updates to scenario * add default 'system' filters, format api_benchmark * optional filters, remove cruft, fix list urls * added separate VU params * re-add old change_configmaps.js, rename new configmap script * add potential threshold updates, resolve various feedback points * move script to vai dir * fix per-scenario thresholds * final threshold fix
git-ival
force-pushed
the
add-rtbs-test
branch
from
a1710fa to
320f9c9
Compare
rancher-max
reviewed
Oct 20, 2025
Member
rancher-max
left a comment
rancher-max
left a comment
There was a problem hiding this comment.
This is overall in an okay spot. I know it popped up randomly in some of your old work, so no need to address the comments right away, but I do think they should be addressed before merging.
rancher-max
approved these changes
Oct 22, 2025
Member
rancher-max
left a comment
rancher-max
left a comment
There was a problem hiding this comment.
LGTM -- I'll let you decide what you want to do about the sleeps. Responded to that comment directly 👍
rancher-max
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this lingering on the wrong branch. Adds a negative path test that expects a failure to create projects. May not need this to be merged, but I figured its worth a review.