fixed some small things when working with vsphere provisioner#13
Open
aSauerwein wants to merge 8 commits intorancher:mainfrom
Open
fixed some small things when working with vsphere provisioner#13aSauerwein wants to merge 8 commits intorancher:mainfrom
aSauerwein wants to merge 8 commits intorancher:mainfrom
Conversation
aSauerwein
commented
Jan 4, 2023
aSauerwein
commented
- prepend cluster name to nodepool to make them unique. ( otherwise you cannot name your node pool 'cpl' across 2 clusters )
- add option to define machineselectorconfig ( for example for system registry settings )
- add registries / mirrors
- add node pool os to deploy windows node pools
- vapp properties should be a list
- cfgparam should also be a list
aSauerwein
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.