Skip to content

call widget.resize when slides are shown #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

call widget.resize when slides are shown #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions inst/www/htmlwidgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,20 +588,13 @@
"hidden.htmlwidgets hidden.bs.tab.htmlwidgets hidden.bs.collapse.htmlwidgets",
resizeHandler
);
}

// This is needed for the specific case of ioslides, which
// flips slides between display:none and display:block.
// Ideally we would not have to have ioslide-specific code
// here, but rather have ioslides raise a generic event,
// but the rmarkdown package just went to CRAN so the
// window to getting that fixed may be long.
if (window.addEventListener) {
// It's OK to limit this to window.addEventListener
// browsers because ioslides itself only supports
// such browsers.
on(document, "slideenter", resizeHandler);
on(document, "slideleave", resizeHandler);
// subscribe to custom shown event fired by ioslides and reveal.js (and
// perhaps other slide frameworks). This is necessary because some widgets
// (e.g. dygraphs) which start out as display:none have height == 0 and
// width == 0 and this doesn't change when it becomes visible
window.jQuery(el).closest('slide').on('shown', resizeHandler);
window.jQuery(el).closest('section.slide').on('shown', resizeHandler);
}
}

Expand Down