Bounty #427: Add proof activity search links#549
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds a "Related activity" section to the bounty payment proof page. When a proof represents a bounty payment, the page now displays a metadata grid with searchable activity links for the recipient account, proof hash, bounty ID, and submission URL. A test verifies the section renders with the correct search parameters. ChangesBounty proof related activity
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
bitdamii
left a comment
There was a problem hiding this comment.
Reviewed current head 2789519 for proof-to-activity navigation.
Evidence checked: app/templates/proof.html and tests/test_bounty_pages.py. The change only adds local /activity?q= links on bounty_payment proof pages, uses the existing Jinja urlencode path for query values, keeps external submission URL display behind safe_public_url, and extends the existing proof scannability test to recipient, proof hash, bounty id, and submission URL activity searches.
Local validation:
- uv run --extra dev python -m pytest tests/test_bounty_pages.py -q -> 7 passed
- uv run --extra dev ruff check tests/test_bounty_pages.py -> passed
- uv run --extra dev ruff format --check tests/test_bounty_pages.py -> passed
- uv run --extra dev mypy app -> success
- uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
- git diff --check origin/main...HEAD -> clean
GitHub Quality/readiness/docs/image check is successful. CodeRabbit was still pending at review time. No blocker found in this reviewed slice.
peterxing
left a comment
There was a problem hiding this comment.
No blockers found on PR #549 at head 2789519.
Evidence checked:
- Inspected
app/templates/proof.html: the new Related activity section is shown only forbounty_paymentproofs, and the four links useurlencodefor recipient account, proof hash, bounty id, and submission URL query values. - Inspected
tests/test_bounty_pages.py: the existing proof-page scannability regression now asserts the recipient, proof-hash, bounty-id, and submission activity links. - Hosted
Quality, readiness, docs, and image checksis green on the PR head. CodeRabbit was still pending when I reviewed, so this review is scoped to the diff and local checks below.
Validation run locally on PR head 2789519:
..\..\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py::test_ledger_and_proof_pages_make_bounty_payments_scannable -q-> 1 passed..\..\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py -q-> 7 passed..\..\.venv\Scripts\python.exe -m ruff check tests\test_bounty_pages.py-> passed..\..\.venv\Scripts\python.exe -m ruff format --check tests\test_bounty_pages.py-> 1 file already formattedgit diff --check origin/main...HEAD-> clean
No secrets, wallet material, private payout details, deployment values, private vulnerability details, or MRWK price/cash-out claims were included.
|
Reviewed PR #549 at Evidence checked:
Validation:
Assessment: no blocker found. The change is narrowly scoped to audit/navigation links on bounty payment proof pages and does not alter proof generation or payout behavior. |
Bounty #427: Add proof activity search links
Summary:
Before/after:
/activity?q=...links for the adjacent recipient, proof, bounty, and submission audit views.Validation:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests/test_bounty_pages.py::test_ledger_and_proof_pages_make_bounty_payments_scannable -q-> 1 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests/test_bounty_pages.py -q-> 7 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest -q-> 414 passed.\.venv\Scripts\python.exe -m ruff check .-> passed.\.venv\Scripts\python.exe -m ruff format --check tests\test_bounty_pages.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m mypy app-> successPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke okgit diff --check-> clean, except Git's Windows LF-to-CRLF warning for the touched templateRefs #427
No wallet material, private keys, cookies, OAuth state, access tokens, signatures, browser storage, private data, price/liquidity/exchange/bridge/off-ramp claims, or fabricated payout claims are included.
Summary by CodeRabbit