Skip to content

Bounty #427: Add proof activity search links#549

Open
ifanatics-media wants to merge 1 commit into
ramimbo:mainfrom
ifanatics-media:codex/427-proof-activity-links
Open

Bounty #427: Add proof activity search links#549
ifanatics-media wants to merge 1 commit into
ramimbo:mainfrom
ifanatics-media:codex/427-proof-activity-links

Conversation

@ifanatics-media
Copy link
Copy Markdown

@ifanatics-media ifanatics-media commented May 28, 2026

Bounty #427: Add proof activity search links

Summary:

  • Public bounty payment proof pages now show a Related activity section with accepted-work searches for recipient, proof hash, bounty id, and submission URL.
  • This turns an accepted proof into direct audit and navigation entry points without copying account, hash, bounty, or submission values by hand.
  • The change is distinct from PR [codex] collapse raw proof JSON on public proof page #467, which collapses raw proof JSON; this adds proof-to-activity navigation.

Before/after:

  • Before: proof pages linked to the account, bounty, ledger entry, and submission, but accepted-work activity search required manual copy/paste.
  • After: proof pages include direct /activity?q=... links for the adjacent recipient, proof, bounty, and submission audit views.

Validation:

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests/test_bounty_pages.py::test_ledger_and_proof_pages_make_bounty_payments_scannable -q -> 1 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest tests/test_bounty_pages.py -q -> 7 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m pytest -q -> 414 passed
  • .\.venv\Scripts\python.exe -m ruff check . -> passed
  • .\.venv\Scripts\python.exe -m ruff format --check tests\test_bounty_pages.py -> passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe -m mypy app -> success
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .\.venv\Scripts\python.exe scripts\docs_smoke.py -> docs smoke ok
  • git diff --check -> clean, except Git's Windows LF-to-CRLF warning for the touched template

Refs #427

No wallet material, private keys, cookies, OAuth state, access tokens, signatures, browser storage, private data, price/liquidity/exchange/bridge/off-ramp claims, or fabricated payout claims are included.

Summary by CodeRabbit

  • New Features
    • Added "Related activity" section to bounty proof pages that displays searchable links for the recipient account, proof hash, bounty ID, and submission URL, enabling users to quickly discover and explore all connected transactions and related activity associated with their bounty payments.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5fba76ba-7d18-47c0-8b1f-83298c251483

📥 Commits

Reviewing files that changed from the base of the PR and between d8532d4 and 2789519.

📒 Files selected for processing (2)
  • app/templates/proof.html
  • tests/test_bounty_pages.py

📝 Walkthrough

Walkthrough

The PR adds a "Related activity" section to the bounty payment proof page. When a proof represents a bounty payment, the page now displays a metadata grid with searchable activity links for the recipient account, proof hash, bounty ID, and submission URL. A test verifies the section renders with the correct search parameters.

Changes

Bounty proof related activity

Layer / File(s) Summary
Related activity section for bounty proof
app/templates/proof.html, tests/test_bounty_pages.py
Proof page renders a "Related activity" section with URL-encoded activity search links for recipient, proof hash, bounty ID, and submission URL when proof.kind == "bounty_payment". Test assertions verify section presence and search URL correctness.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Bounty #427: Add proof activity search links' clearly and concretely names the changed surface, is directly related to the main change (adding activity search links to proof pages), and includes the bounty reference as expected.
Description check ✅ Passed The description includes all required template sections: Summary with clear bullet points, Evidence with confusion/bug addressed and intended files, comprehensive Test Evidence with all validation commands and results, and Related bounty reference. The author provided detailed before/after context and validation evidence.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed PR adds navigation links to proof pages with no investment, price, cash-out, or security claims. Changes are limited to template UI improvements and corresponding test updates only.
Bounty Pr Focus ✅ Passed PR changes match stated scope: 2 files modified, 35 lines added, conditional bounty_payment logic, 4 activity search links with URL encoding, and test coverage for all assertions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@bitdamii bitdamii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 2789519 for proof-to-activity navigation.

Evidence checked: app/templates/proof.html and tests/test_bounty_pages.py. The change only adds local /activity?q= links on bounty_payment proof pages, uses the existing Jinja urlencode path for query values, keeps external submission URL display behind safe_public_url, and extends the existing proof scannability test to recipient, proof hash, bounty id, and submission URL activity searches.

Local validation:

  • uv run --extra dev python -m pytest tests/test_bounty_pages.py -q -> 7 passed
  • uv run --extra dev ruff check tests/test_bounty_pages.py -> passed
  • uv run --extra dev ruff format --check tests/test_bounty_pages.py -> passed
  • uv run --extra dev mypy app -> success
  • uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • git diff --check origin/main...HEAD -> clean

GitHub Quality/readiness/docs/image check is successful. CodeRabbit was still pending at review time. No blocker found in this reviewed slice.

Copy link
Copy Markdown

@peterxing peterxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers found on PR #549 at head 2789519.

Evidence checked:

  • Inspected app/templates/proof.html: the new Related activity section is shown only for bounty_payment proofs, and the four links use urlencode for recipient account, proof hash, bounty id, and submission URL query values.
  • Inspected tests/test_bounty_pages.py: the existing proof-page scannability regression now asserts the recipient, proof-hash, bounty-id, and submission activity links.
  • Hosted Quality, readiness, docs, and image checks is green on the PR head. CodeRabbit was still pending when I reviewed, so this review is scoped to the diff and local checks below.

Validation run locally on PR head 2789519:

  • ..\..\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py::test_ledger_and_proof_pages_make_bounty_payments_scannable -q -> 1 passed
  • ..\..\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py -q -> 7 passed
  • ..\..\.venv\Scripts\python.exe -m ruff check tests\test_bounty_pages.py -> passed
  • ..\..\.venv\Scripts\python.exe -m ruff format --check tests\test_bounty_pages.py -> 1 file already formatted
  • git diff --check origin/main...HEAD -> clean

No secrets, wallet material, private payout details, deployment values, private vulnerability details, or MRWK price/cash-out claims were included.

@tinyopsstudio
Copy link
Copy Markdown

Reviewed PR #549 at 27895194836efb480361e363ce7d375fad2ebe8f for the proof-to-activity navigation slice.

Evidence checked:

  • inspected app/templates/proof.html and tests/test_bounty_pages.py;
  • confirmed the new Related activity block is only rendered for proof.kind == "bounty_payment";
  • confirmed the recipient, proof hash, bounty id, and submission URL links all point to local /activity?q=... searches and use Jinja urlencode for query values;
  • confirmed the existing public submission link remains behind safe_public_url, while the new activity search link is local navigation rather than a new external URL surface.

Validation:

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_bounty_pages.py::test_ledger_and_proof_pages_make_bounty_payments_scannable -q -> 1 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_bounty_pages.py -q -> 7 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q -> 414 passed
  • uv run --extra dev ruff check tests/test_bounty_pages.py -> passed
  • uv run --extra dev ruff format --check tests/test_bounty_pages.py -> 1 file already formatted
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • git diff --check origin/main...HEAD -> clean

Assessment: no blocker found. The change is narrowly scoped to audit/navigation links on bounty payment proof pages and does not alter proof generation or payout behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants