Add contributor shortcuts to me page#543
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR extracts a ChangesGitHub account shortcuts and links
Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Baijack-star
left a comment
There was a problem hiding this comment.
Reviewed PR #543 at head b1dc1af for the signed-in /me contributor-shortcuts slice.
Evidence checked:
- Diff is limited to app/me.py, app/templates/me.html, tests/test_me_page.py, and tests/test_wallet_api.py.
- app/me.py builds github_account once from the authenticated login and reuses it for balance lookup and template links.
- app/templates/me.html adds the contributor shortcut links only inside the signed-in branch, so anonymous users do not get empty /accounts/ links.
- The activity shortcut URL-encodes github:alice as github%3Aalice, matching the public activity query contract, and the linked-wallet shortcut is conditional on linked_wallet_address.
- Existing wallet/link/claim forms stay below the shortcut section and the new tests cover both linked and unlinked states.
Validation run locally on the PR branch:
- PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_me_page.py tests/test_wallet_api.py::test_me_page_shows_signed_in_github_claim_balance tests/test_wallet_api.py::test_me_page_prefills_claim_address_for_linked_wallet -q -> 4 passed
- uv run --extra dev ruff check app/me.py tests/test_me_page.py tests/test_wallet_api.py -> All checks passed
- git diff --check origin/main...HEAD -> clean
Assessment: no code blocker found in this focused navigation addition. The GitHub status shows the main Quality/readiness/docs/image check successful; CodeRabbit was still processing at review time, so maintainers may still get automated follow-up. No private cookies, tokens, wallet material, production mutation, payout guarantees, liquidity/exchange/off-ramp claims, or private data were used.
|
Reviewed PR #543 at Evidence checked:
Validation:
Assessment: no blocker found. The change is scoped to the authenticated contributor page and gives the user direct inspection links without changing the wallet signing/claim flow. |
Bounty #427
Summary:
/meshortcuts to the contributor ledger account, accepted-work activity search, account JSON, and linked wallet detail when availableEvidence:
/meshowedgithub:<login>balance and linked-wallet state, but users had to manually compose/accounts/github:<login>,/activity?q=github:<login>, or/api/v1/accounts/github:<login>URLs to inspect public history and machine-readable account statestatus=open,awards_remaining=2,available_mrwk=250, and no active attemptsVerification:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_me_page.py tests/test_wallet_api.py::test_me_page_shows_signed_in_github_claim_balance tests/test_wallet_api.py::test_me_page_prefills_claim_address_for_linked_wallet -q-> 4 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_me_page.py tests/test_wallet_api.py tests/test_account_routes.py tests/test_activity.py -q-> 40 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q-> 414 passeduv run --extra dev ruff check app/me.py tests/test_me_page.py tests/test_wallet_api.py-> passeduv run --extra dev ruff format --check app/me.py tests/test_me_page.py tests/test_wallet_api.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev mypy app/me.py-> successPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check-> cleanSummary by CodeRabbit