Auto-select scheme in api_check_lockfile and document it#218
Merged
Conversation
Pick http for localhost/127.0.0.1 hosts, https otherwise. Drop the manual API_SCHEME=https from the non-local example since it's now the default. Keep API_SCHEME as an override for edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/api_check_lockfilenow auto-selectshttpforlocalhost/127.0.0.1andhttpsfor any other host, so the commonAPI_HOST=api.railsbump.org …invocation no longer needs an explicitAPI_SCHEME=https.API_SCHEMEis still honored as an override for edge cases (e.g. a remote host over plain HTTP).docs/api_check_lockfile.mdto match: simpler non-local example, plus a note describing the auto-select behavior and when to override.