Skip to content

Optimize _map_collection #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moberegger wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Optimize _map_collection #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/jbuilder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,11 @@ def _set_value(key, value)
end

def _map_collection(collection)
collection.map do |element|
collection = collection.map do |element|
_scope{ yield element }
end - [BLANK]
end
collection.delete(BLANK)
Copy link
Contributor Author

@moberegger moberegger Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe to mutate because the result of the map is local to the method. The input remains unaffected.

collection
end

def _scope
Expand Down