Remove Validations deprecation code #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ActiveResource::Validations#from_json` method emits deprecation
warnings when handling error response payloads that resemble the
following:
```
{"errors":["First cannot be empty"]}
{"first":["cannot be empty"]}
```
The deprecation was originally introduced in [c643605][] (Feb 4, 2012).
This commit removes documentation mentions of backwards-compatibility
along with the conditional branches that emit the deprecation warnings.
The removal of the backwards support is a breaking change.
[c643605]: rails@c643605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ActiveResource::Validations#from_jsonmethod emits deprecation warnings when handling error response payloads that resemble the following:{"errors":["First cannot be empty"]} {"first":["cannot be empty"]}The deprecation was originally introduced in c643605 (Feb 4, 2012). This commit removes documentation mentions of backwards-compatibility along with the conditional branches that emit the deprecation warnings.
The removal of the backwards support is a breaking change.