Conversation
Author
|
FYI, our codebase is checked by Sorbet, and I did see this error Method 'delete_all' does not exist on 'NilClass component of 'T.nilable(ActiveRecord::Batches:: BatchEnumerator)' (fix available)I was able to resolve it by using Since this gem does not have Sorbet, I opted to not include the |
chaadow
reviewed
Aug 15, 2024
| @@ -16,6 +16,7 @@ namespace 'db:sessions' do | |||
| cutoff_period = (ENV['SESSION_DAYS_TRIM_THRESHOLD'] || 30).to_i.days.ago | |||
| ActiveRecord::SessionStore::Session. | |||
| where("updated_at < ?", cutoff_period). | |||
There was a problem hiding this comment.
Nice! However, even this solution gave me a timeout, but at least it deleted many batches instead of nothing
what i'm gonna try is add some throttling between each batch (like suggested in rails docs )
|
Encountering this same issue. It would be nice if the batch logic was incorporated so that running this task in a background job will eventually delete the data. Batch size could probably be much higher, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to some unforeseen events, we hit the MySQL timeout when trimming our sessions.
We've implemented a batched approach in our own codebase, but I figured this might be beneficial to the gem itself.
Not sure this change warrants any tests (and if so, what the best way is to implement these), so open to suggestions on that.