WIP: Benchmark with cache that supports read-multi #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
changed the title
bf4
force-pushed
the
bench_multi
branch
2 times, most recently
from
559108c to
126e771
Compare
bin/bench -r 5
Benchmark results:
{
"commit_hash": "617c8a7",
"version": "0.10.0",
"rails_version": "4.2.6",
"benchmark_run[environment]": "2.2.3p173",
"runs": [
{
"benchmark_type[category]": "caching on: caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 669.362,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1341
},
{
"benchmark_type[category]": "caching on: fragment caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 628.208,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1433
},
{
"benchmark_type[category]": "caching on: non-caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 1008.955,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1230
},
{
"benchmark_type[category]": "caching off: caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 605.704,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1341
},
{
"benchmark_type[category]": "caching off: fragment caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 560.369,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1433
},
{
"benchmark_type[category]": "caching off: non-caching serializers: gc off",
"benchmark_run[result][iterations_per_second]": 868.604,
"benchmark_run[result][total_allocated_objects_per_iteration]": 1230
}
]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(needs to be rebased when #1785 is merged)
Just sharing in case anyone's interested in contributing ideas.
cc @sorentwo
Benchmark command:
bin/bench -r 5before
after
{ "commit_hash": "461ba7a", "version": "0.10.0", "rails_version": "4.2.6", "benchmark_run[environment]": "2.2.3p173", "runs": [ { "benchmark_type[category]": "caching on: caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 672.108, "benchmark_run[result][total_allocated_objects_per_iteration]": 1344 }, { "benchmark_type[category]": "caching on: fragment caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 498.769, "benchmark_run[result][total_allocated_objects_per_iteration]": 1779 }, { "benchmark_type[category]": "caching on: non-caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 970.039, "benchmark_run[result][total_allocated_objects_per_iteration]": 1230 }, { "benchmark_type[category]": "caching off: caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 588.077, "benchmark_run[result][total_allocated_objects_per_iteration]": 1344 }, { "benchmark_type[category]": "caching off: fragment caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 450.344, "benchmark_run[result][total_allocated_objects_per_iteration]": 1779 }, { "benchmark_type[category]": "caching off: non-caching serializers: gc off", "benchmark_run[result][iterations_per_second]": 856.79, "benchmark_run[result][total_allocated_objects_per_iteration]": 1230 } ] }currently intended to be used in #1781