Skip to content

Dev container lockfile for reproducible feature pinning#11410

Open
brooke-hamilton wants to merge 3 commits intomainfrom
brooke-hamilton/devcontainer-lock
Open

Dev container lockfile for reproducible feature pinning#11410
brooke-hamilton wants to merge 3 commits intomainfrom
brooke-hamilton/devcontainer-lock

Conversation

@brooke-hamilton
Copy link
Member

@brooke-hamilton brooke-hamilton commented Mar 11, 2026

Description

Add a devcontainer-lock.json file to pin dev container features to exact versions with SHA-256 integrity hashes, ensuring reproducible dev container builds across contributors. Also add contributor documentation explaining how to check for outdated features, update the lockfile, and verify changes.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@brooke-hamilton brooke-hamilton requested review from a team as code owners March 11, 2026 05:24
Copilot AI review requested due to automatic review settings March 11, 2026 05:24
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds dev container feature locking to make contributor devcontainer builds reproducible and documents the workflow for maintaining the lockfile.

Changes:

  • Introduces .devcontainer/devcontainer-lock.json to pin dev container feature versions and integrity hashes.
  • Updates contributor prerequisites docs with instructions for checking/updating/verifying the lockfile.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/contributing/contributing-code/contributing-code-prerequisites/README.md Documents how contributors update and verify the dev container lockfile.
.devcontainer/devcontainer-lock.json New lockfile capturing exact devcontainer feature versions and SHA-256 digests.

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 11, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 5a29e16
Unique ID func99a2909217
Image tag pr-func99a2909217
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func99a2909217
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func99a2909217
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func99a2909217
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func99a2909217
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func99a2909217
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@github-actions
Copy link

Unit Tests

    2 files  ±0    415 suites  ±0   6m 49s ⏱️ -2s
4 881 tests ±0  4 879 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 783 runs  ±0  5 781 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5a29e16. ± Comparison against base commit acf4805.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.22%. Comparing base (acf4805) to head (5a29e16).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11410   +/-   ##
=======================================
  Coverage   51.22%   51.22%           
=======================================
  Files         699      699           
  Lines       44062    44062           
=======================================
+ Hits        22570    22572    +2     
+ Misses      19331    19330    -1     
+ Partials     2161     2160    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@DariuszPorowski DariuszPorowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@radius-functional-tests
Copy link

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 5a29e16
Unique ID func5bc7ebae48
Image tag pr-func5bc7ebae48
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5bc7ebae48
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5bc7ebae48
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5bc7ebae48
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func5bc7ebae48
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5bc7ebae48
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants