Correct Helm flag from --set-string to --set in docs and CLI examples#11404
Correct Helm flag from --set-string to --set in docs and CLI examples#11404brooke-hamilton wants to merge 2 commits intoradius-project:mainfrom
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates Radius documentation and CLI help examples to use Helm-style --set (instead of --set-string) when setting global.imagePullSecrets[*].name, aligning examples with the intended Helm values usage.
Changes:
- Replaced
--set-stringwith--setinrad install,rad init, andrad upgradeCLI example text. - Updated contributing docs to use
--setforglobal.imagePullSecretsexamples. - Updated the Helm chart README’s
rad installexample to use--set.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deploy/Chart/README.md | Updates CLI example for imagePullSecrets to use --set (but leaves one Helm snippet unchanged). |
| docs/contributing/contributing-code/contributing-code-control-plane/generating-and-installing-custom-build.md | Updates imagePullSecrets example to use --set. |
| docs/contributing/contributing-code/contributing-code-tests/testing-local.md | Updates imagePullSecrets example to use --set. |
| pkg/cli/cmd/install/kubernetes/kubernetes.go | Updates command help examples to use --set. |
| pkg/cli/cmd/radinit/init.go | Updates command help examples to use --set. |
| pkg/cli/cmd/upgrade/kubernetes/kubernetes.go | Updates command help examples to use --set. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11404 +/- ##
==========================================
- Coverage 51.23% 51.22% -0.02%
==========================================
Files 699 699
Lines 44062 44062
==========================================
- Hits 22577 22572 -5
- Misses 19329 19330 +1
- Partials 2156 2160 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Replaces
--set-stringwith--setforglobal.imagePullSecretsin documentation and CLI command examples. The--set-stringflag is unnecessary here because the values being set are already strings, and using--setis the standard and correct approach for these Helm chart values.Type of change
Changes
--set-stringto--setforimagePullSecretsexample--set-stringto--setforimagePullSecretsexample--set-stringto--setforimagePullSecretsexample--setinstead of--set-string--setinstead of--set-string--setinstead of--set-stringContributor checklist
Please verify that the PR meets the following requirements, where applicable: