Add HoldConfirmButton with circular progress ring#28
Merged
Conversation
Introduces a hold-to-confirm pill button that shrinks while pressed and draws a progress ring using Motion styleEffect and svgEffect. Includes docs, registry wiring, and homepage showcase.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove onConfirm handler from MDX preview. Server-rendered docs cannot pass event handlers to client components.
Default stroke is 12px with an SVG goo filter, spring-driven scale squash, and spring rewind. Docs and landing previews no longer wrap the button in a black box.
Fix idle full-circle artifact by initializing stroke-dasharray to zero, gating ring opacity on progress, hiding the SVG while idle, and removing the goo filter SourceGraphic blend.
Stop React from overriding Motion svgEffect by removing controlled opacity and stroke-dash attributes on the circle. Ring visibility is gated on the SVG wrapper state only.
Remove the SVG goo filter that blurred the thick stroke into a full ring on press. Ring opacity and pathLength now both track hold progress for a gradual arc.
Default ringSize is 280px with a tighter radius formula so the arc sits farther from the pill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a hold-to-confirm pill button that shrinks while pressed and draws a progress ring using Motion styleEffect and svgEffect. Includes docs, registry wiring, and homepage showcase.