Enroll without nautobot #1416
Draft
Enroll without nautobot #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekeay
force-pushed
the
enroll-without-nautobot
branch
2 times, most recently
from
76fd166 to
957605f
Compare
We have data freshly discovered from the BMC. We were updating Nautobot, then fetching the same data back from Nautobot to populate Ironic. This code is re-written to use BMC data directly, allowing us to enrol independently from Nautobot. We now expect Nautotbot to be updated in response to events emitted by OpenStack, so there is no need for us to write directly to the Nautobot API.
stevekeay
force-pushed
the
enroll-without-nautobot
branch
from
957605f to
cdd2267
Compare
stevekeay
force-pushed
the
enroll-without-nautobot
branch
from
cdd2267 to
0709c7b
Compare
Interfaces are to be managed by a post-inspection hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nautobot is (or is intended to be) updated by events from OpenStack so we don't need to create anything in Nautobot on enrol.
We remove a lot of other functionality from the enrol script, with the intention that #1347 and other changes will take on some of the responsibility in post-inspection hooks.
Specifically we no longer do anything with interfaces or flavors.