4.3: Implement AMQP-1.0 delivery-count for CQs #15020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to accurately express delivery-count CQs were updated to better handle modified outcomes, particularly the delivery-failed field. This required modifying the interface of the process and therefore this is protected behind a feature flag.
lhoguin
force-pushed
the
loic-cq-delivery-count-really
branch
from
33e8d31 to
6664d1b
Compare
lhoguin
changed the title
ansd
requested changes
Dec 3, 2025
Member
|
The |
Also don't ignore DelFailed in modified outcome when undeliverable-here is true, so that delivery-count is properly incremented before being propagated to DLQ. Thanks @ansd for hand holding.
ansd
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tell me if there are other tests that need to be updated.