Skip to content

Conversation

gomoripeti
Copy link
Contributor

Proposed Changes

Context: Management UI > Shovel Management Tab > "Add a new shovel" section.

There was no input field to set the number for delete-after "After num messages" parameter for local shovels as opposed to AMQP 1.0 shovels.

The help text was also missing for local shovel auto-delete. (The ? showed an empty popup when Local protocol is selected for Source)

The solution is just a copy past from AMQP 1.0

Setting delete-after to a number when creating a local shovel still doesn't work as the value is sent in the PUT json as a string instead of a number. Doing the same with an AMQP 1.0 works fine sending a json number. Where the conversion happens on the frontend is beyond my understanding of the Mgmt javascript. I would need some help to address this part.

{
  "component": "shovel",
  "vhost": "/",
  "name": "s2",
  "value": {
    "src-uri": "amqp://",
    "dest-uri": "amqp://",
    "ack-mode": "on-confirm",
    "src-protocol": "local",
    "dest-protocol": "local",
    "src-queue": "cq1",
    "src-delete-after": "3", <--- string instead of number
    "dest-queue": "cq2",
    "dest-add-forward-headers": false
  }
}

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • [c] Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

There was no input field to set the number for src-delete-after
parameter.

The help text was also missing for local shovel auto-delete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant