Open
Conversation
JH456
commented
Dec 31, 2018
JH456
commented
- Uses a baby blockchain to track details about each file revision (copy/pastes from other files and timestamps)
- Breaks backwards compatibility with older versions (i.e you can't open up old .sim files with this version. Need to copy the file contents into a new file)
ra4king
reviewed
Jan 4, 2019
ra4king
reviewed
Jan 4, 2019
Co-Authored-By: JH456 <betterjimmy456@gmail.com>
Co-Authored-By: JH456 <betterjimmy456@gmail.com>
ra4king
requested changes
Sep 19, 2022
| String decodedBlock = new String(Base64.getDecoder().decode(stringifiedBlock.getBytes())); | ||
| String[] fields = decodedBlock.split("\t"); | ||
| if (fields.length < 4) { | ||
| throw new NullPointerException("File is corrupted. Contact Course Staff for Assistance."); |
Owner
There was a problem hiding this comment.
I don't like "Contact course staff for assistance" because I want to keep course-specific content out of this. Perhaps: "File hash mismatch: file is corrupted."
| return parse(readFile(file)); | ||
| CircuitFile savedFile = parse(readFile(file)); | ||
| if (!savedFile.revisionSignaturesAreValid()) { | ||
| throw new NullPointerException("File is corrupted. Contact Course Staff for Assistance."); |
Owner
|
I reviewed these changes years ago but apparently my comments never actually went out for review, they were pending this whole time /facepalm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.