Skip to content

Fix flakey session lifecycle coordinator test #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmedre merged 1 commit into from
Jun 22, 2026
Merged

Fix flakey session lifecycle coordinator test #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions ...elines/src/commonTest/kotlin/com/quran/shared/pipeline/SessionLifecycleCoordinatorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ class SessionLifecycleCoordinatorTest {
val coordinator = SessionLifecycleCoordinator(store)
val activeWriteStarted = CompletableDeferred<Unit>()
val allowActiveWriteToFinish = CompletableDeferred<Unit>()
val resetRequestStarted = CompletableDeferred<Unit>()
val resetBlockStarted = CompletableDeferred<Unit>()
var secondWriteRan = false

Expand All @@ -177,11 +178,13 @@ class SessionLifecycleCoordinatorTest {
activeWriteStarted.await()

val resetJob = async {
coordinator.runManagedReset {
coordinator.runManagedReset(
beforeWriteDrain = { resetRequestStarted.complete(Unit) }
) {
resetBlockStarted.complete(Unit)
}
}
runCurrent()
resetRequestStarted.await()

val secondWrite = async {
assertFailsWith<SessionResetInProgressException> {
Expand Down Expand Up @@ -213,6 +216,7 @@ class SessionLifecycleCoordinatorTest {
val coordinator = SessionLifecycleCoordinator(store)
val activeWriteStarted = CompletableDeferred<Unit>()
val allowActiveWriteToFinish = CompletableDeferred<Unit>()
val resetRequestStarted = CompletableDeferred<Unit>()
val resetBlockStarted = CompletableDeferred<Unit>()
var recoveryBlockRan = false

Expand All @@ -226,11 +230,13 @@ class SessionLifecycleCoordinatorTest {
activeWriteStarted.await()

val reset = async {
coordinator.runManagedReset {
coordinator.runManagedReset(
beforeWriteDrain = { resetRequestStarted.complete(Unit) }
) {
resetBlockStarted.complete(Unit)
}
}
runCurrent()
resetRequestStarted.await()

assertEquals(true, store.snapshot().resetInProgress)
assertEquals(false, resetBlockStarted.isCompleted)
Expand Down Expand Up @@ -347,6 +353,7 @@ class SessionLifecycleCoordinatorTest {
val epoch = coordinator.captureSyncEpoch()
val completionStarted = CompletableDeferred<Unit>()
val completionCanFinish = CompletableDeferred<Unit>()
val resetRequestStarted = CompletableDeferred<Unit>()
val resetCanFinish = CompletableDeferred<Unit>()
var writeBlockRan = false

Expand All @@ -359,11 +366,13 @@ class SessionLifecycleCoordinatorTest {
completionStarted.await()

val reset = async {
coordinator.runManagedReset {
coordinator.runManagedReset(
beforeWriteDrain = { resetRequestStarted.complete(Unit) }
) {
resetCanFinish.await()
}
}
runCurrent()
resetRequestStarted.await()

val write = async {
assertFailsWith<SessionResetInProgressException> {
Expand Down Expand Up @@ -443,6 +452,7 @@ class SessionLifecycleCoordinatorTest {
val coordinator = SessionLifecycleCoordinator(store)
val activeWriteStarted = CompletableDeferred<Unit>()
val activeWriteCanFinish = CompletableDeferred<Unit>()
val resetRequestStarted = CompletableDeferred<Unit>()
val resetCanFinish = CompletableDeferred<Unit>()
var recoveryBlockRan = false

Expand All @@ -455,11 +465,13 @@ class SessionLifecycleCoordinatorTest {
activeWriteStarted.await()

val reset = async {
coordinator.runManagedReset {
coordinator.runManagedReset(
beforeWriteDrain = { resetRequestStarted.complete(Unit) }
) {
resetCanFinish.await()
}
}
runCurrent()
resetRequestStarted.await()

assertEquals(true, store.snapshot().resetInProgress)

Expand Down