User List View #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…center router views
…g logic into composable
…hould be considered for a bigger prod application
feat: add a basic check if an email already exists.
…mprove display logic
schogges
reviewed
Aug 25, 2025
Contributor
There was a problem hiding this comment.
Ideally this is part of the components package. Did you use npx shadcn-vue@latest add toast to add the component? (ref: https://www.shadcn-vue.com/docs/components/toast.html)
Comment on lines
+4
to
+21
| <div class="flex gap-2"> | ||
| <Input | ||
| v-model="newName" | ||
| placeholder="Name" | ||
| class="flex-1" | ||
| /> | ||
| <Input | ||
| v-model="newEmail" | ||
| placeholder="Email" | ||
| class="flex-1" | ||
| /> | ||
| </div> | ||
| <Button | ||
| class="bg-slate-500 hover:bg-blue-400 text-white" | ||
| @click="createNewUser" | ||
| > | ||
| Create new user | ||
| </Button> |
Contributor
There was a problem hiding this comment.
Could we use a native <form> for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an exemplary user list view where users can be added and deleted. Gotten a little out of hand :D