Fix Windows IPv6 bind option selection#2691
Open
nkgotcode wants to merge 2 commits into
Open
Conversation
nkgotcode
requested review from
Ralith,
djc,
gretchenfrage,
mxinden and
thomaseizinger
as code owners
June 18, 2026 16:10
Collaborator
|
Thanks for looking into this! The issue claims that the bug was introduced in b8e4d3b, which doesn't involve quinn-udp, so I don't think these changes are sufficient, and I'm not sure if they're necessary either, though they do make sense intuitively. Please add an end-to-end test at the quinn level to be sure we capture (and don't regress) the behavior of the whole stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2682.
This changes the Windows UDP socket setup so IPv4 packet-info options are only
enabled for IPv4 sockets and wildcard dual-stack IPv6 sockets. Non-wildcard
IPv6 binds such as
[::1]:4433no longer take the IPv4 option path.Testing:
cargo test -p quinn-udp --no-default-features