streams: reject STOP_SENDING and MAX_STREAM_DATA beyond the stream limit#2652
Open
c-tonneslan wants to merge 1 commit into
Open
streams: reject STOP_SENDING and MAX_STREAM_DATA beyond the stream limit#2652c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
received_reset already runs validate_receive_id, so a RESET_STREAM referencing a stream ID past the limit we advertised is caught as a STREAM_LIMIT_ERROR. received_stop_sending and received_max_stream_data never had an equivalent check, so a peer could send STOP_SENDING or MAX_STREAM_DATA for a stream it was never allowed to open and we'd just ignore the frame instead of treating it as a protocol violation. Add validate_remote_stream_limit and call it from both. Locally initiated streams are still bounded by the existing is_local_unopened checks, so this only tightens handling of peer-initiated stream IDs. Closes quinn-rs#2650 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2650.
received_resetrunsvalidate_receive_id, so a RESET_STREAM that references a stream ID past the limit we advertised gets caught as aSTREAM_LIMIT_ERROR.received_stop_sendingandreceived_max_stream_datanever had the equivalent check, so a peer could send STOP_SENDING or MAX_STREAM_DATA for a bidi stream it was never allowed to open and we'd silently ignore the frame instead of raising a protocol violation.I pulled the check into
validate_remote_stream_limitand call it from both handlers. Locally initiated streams stay bounded by the existingis_local_unopenedchecks, so this only tightens handling of peer-initiated stream IDs. Added unit tests for both frames covering the within-limit and over-limit cases.