refactor(quinn-proto): Use ArrayRangeSet in favor of RangeSet
#2445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to improve performance by ~8-10% in local benchmarks for us.
matheus23
requested review from
Ralith,
djc and
gretchenfrage
as code owners
djc
approved these changes
Nov 13, 2025
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Nice and simple, and seems plausible?
Contributor
Author
|
I would hold off on merging this too eagerly. For me this improves some benchmarks by quite a bit, but others also regress. Mostly this tells me that overall CPU use seems to depend on the range set performance characteristics. |
Collaborator
|
Another concern that bears some thought is the hazard of a CPU DoS attack. A peer can exert substantial control over the number of ranges in these fields, and the B tree structure is less sensitive to total size, though how much this matters depends on the exact accesses we're performing. |
Collaborator
|
#2422 will also improve some B-tree operations, which might tilt the balance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to improve performance by ~8-10% in local benchmarks for me.