indexing: label published split docs by publication type - #6647
Open
Noyt wants to merge 3 commits into
Open
Conversation
Author
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Noyt
marked this pull request as ready for review
July 31, 2026 15:51
guilload
self-requested a review
July 31, 2026 17:56
Member
|
I'll review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a bounded
publication_typelabel toquickwit_indexing_published_split_*.initialidentifies publications with no replaced splits.replacementidentifies merge and delete-rewrite publications.This lets consumers count initial published documents without relying on
merge_ops:0, which delete rewrites can preserve.Testing
cargo test --offline -p quickwit-indexing test_publisher_ -- --nocapturecargo clippy --offline -p quickwit-indexing --tests -- -D warnings