-
Notifications
You must be signed in to change notification settings - Fork 495
feat: Prefix and Wildcard in Elastic DSL #6000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prefix and Wildcard in Elastic DSL #6000
Conversation
Signed-off-by: Darkheir <[email protected]>
|
Could you please add a test in quickwit/rest-api-tests/scenarii/es_compatibility that you also run against ES? thanks! |
Signed-off-by: Darkheir <[email protected]>
Signed-off-by: Darkheir <[email protected]>
bf5497e to
4c019ee
Compare
Signed-off-by: Darkheir <[email protected]>
0da0f62 to
f2681ad
Compare
Done :-) |
trinity-1686a
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Can you just change escape sequences to raw strings before we merge?
you don't need to add boost (though you're free to, here or in a follow up, if you want)
Signed-off-by: Darkheir <[email protected]>
|
Thank you for the review :-) I just applied your suggestions. |
* feat: Prefix and Wildcard in Elastic DSL Signed-off-by: Darkheir <[email protected]> * chore: Add licence header Signed-off-by: Darkheir <[email protected]> * feat: Add integration tests Signed-off-by: Darkheir <[email protected]> * feat: Add support for short request format Signed-off-by: Darkheir <[email protected]> * Apply PR review sugestion Signed-off-by: Darkheir <[email protected]> --------- Signed-off-by: Darkheir <[email protected]>
Description
Add support for
prefixandwildcardquery operators in the elasticsearch DSLHow was this PR tested?
Added unit tests