Skip to content

Conversation

@Laeeth
Copy link

@Laeeth Laeeth commented May 14, 2017

Hi.

It's not in shape for you to just accept, as I guess you might want to make use of the allocator optional.

And for deallocation, I do:
scope(exit)
csvAllocator.deallocateAll();

Once I have finished parsing CSV files. Probably a better way to do this!

@Laeeth
Copy link
Author

Laeeth commented May 14, 2017

fwiw when I tested just now on a 34 Meg file I only noticed mine being 10% faster, but I seem to recall it was much more previously (could be many things including runtime getting better). That took about 300 msec, so roughly 100 MB/sec. (My drive does 2.5 GB/sec).

might be interesting to look at this guy who claims astounding performance:
http://www.wise.io/tech/paratext
https://github.com/wiseio/paratext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant