Skip to content

Conversation

@wilson-zh
Copy link
Contributor

Fix #939: Remove unreachable session verification logic

Refactor Session/verify by moving fromCallBack call outside verify, therefore preserves:

  1. original validation order and behavior
  2. accurate method description

@wilson-zh wilson-zh marked this pull request as ready for review December 1, 2025 16:30
@wilson-zh wilson-zh closed this Dec 2, 2025
@wilson-zh wilson-zh reopened this Dec 2, 2025
@chrjohn
Copy link
Member

chrjohn commented Dec 2, 2025

Hi @wilson-zh , thanks for the PR. There is an error in the tests:

2025-12-02T07:24:37.2419690Z quickfix.RuntimeError: java.lang.StackOverflowError
2025-12-02T07:24:37.2420510Z 	at quickfix.Session.next(Session.java:1237)
2025-12-02T07:24:37.2421129Z 	at quickfix.Session.next(Session.java:1284)
2025-12-02T07:24:37.2422384Z 	at quickfix.mina.SingleThreadedEventHandlingStrategy$SessionMessageEvent.processMessage(SingleThreadedEventHandlingStrategy.java:163)
2025-12-02T07:24:37.2424244Z 	at quickfix.mina.SingleThreadedEventHandlingStrategy.block(SingleThreadedEventHandlingStrategy.java:113)
2025-12-02T07:24:37.2425842Z 	at quickfix.mina.SingleThreadedEventHandlingStrategy.lambda$blockInThread$1(SingleThreadedEventHandlingStrategy.java:145)
2025-12-02T07:24:37.2427617Z 	at quickfix.mina.SingleThreadedEventHandlingStrategy$ThreadAdapter$RunnableWrapper.run(SingleThreadedEventHandlingStrategy.java:270)
2025-12-02T07:24:37.2428922Z 	at java.lang.Thread.run(Thread.java:750)
2025-12-02T07:24:37.2429531Z Caused by: java.lang.StackOverflowError
2025-12-02T07:24:37.2430238Z 	at quickfix.Session.validateAndDispatchMsg(Session.java:1804)

The builds were in an endless loop, I just cancelled them.

Could you please take a look at it? Thank you

@wilson-zh wilson-zh force-pushed the fix/939-improve-session-verify branch 2 times, most recently from 3dcb78b to 02a5da6 Compare December 2, 2025 22:34
@wilson-zh wilson-zh requested a review from chrjohn December 2, 2025 23:18
@wilson-zh wilson-zh force-pushed the fix/939-improve-session-verify branch from 02a5da6 to 2cc13c1 Compare December 2, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session#verify is misleading

2 participants