fix: scss leading to invalid css #459
Conversation
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
|
@hawkeye64 are you able to review this otherwise looks like bot may close it? |
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
|
@rstoenescu are you able to review on this repo? To have to constantly bump something to prevent it from being closed is really not contributor friendly if the repo is not actively looked act |
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
|
Closing due to inactivity. |
|
@rstoenescu @hawkeye64 this is pretty absurd to be blunt, to have an auto close bot on a repo not closely looked at is not a great look. It's fine if stuff stays open but just having everything getting closed is ridiculous. I have stucked with quasar for a long while, been a long time donator through my company because of it. My company currently does a sponsorship and would do more but things like this is causing me to lose faith in the future of quasar. |
|
It's a bit absurd for someone to come along and threaten donations on open source. Maybe, a proposed fix would be more appropriate since you're using tools outside the scope of this repo. |
|
So you choose to ghost issues/PRs and not at least choose to engage in a dialog? How is my proposed fix not viable? Do you have any suggestions that would be viable? How is rolldown and lightningcss not within scope? Its the direction of vite, a major part of the vue ecosystem. What else do you want me to do, I want a direction for this resolved. You chose to ignore it, I either move on from this project which if I do I wouldn't donate any further to it. I just got double our donations limit approved for next fiscal, and maintainers that give a good experience are ones who I would more likely donate to |
|
Reopened so I can look into this when time permits. |
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
|
Closing due to inactivity. |
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
|
Bumping |
|
Bumping this pull request because it has been open for 7 days with no activity. Closing automatically in 7 days unless it becomes active again. |
discussion related to this sass/dart-sass#1677
but I was trying to use rolldown which uses lightning-css as a minifier and it was trying to minify the css from this repo and it was complaining about invalid css.
Basically a psuedo selector like before apparently cant have any children selectors as it was outputting
Pseudo-elements like '::before' or '::after' can't be followed by selectors like 'Delim('.')