this is the right way to do light and dark favicon #13097
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
using the media attribute of link tag
unfortunately it only works on Chrome :-(
but it's a very nice way
TODO: also allow project.favicon to choose icon resource
or have {light,dark}
gordonwoodhull
force-pushed
the
feature/favicon-link-media-color-scheme
branch
from
b8144c3 to
80f9f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the
mediaattribute of the<link />tag.E.g.
If this were more than a draft, it would fix #13005.
Unfortunately it only works on Chrome 😦 but it's a very nice, clean way to do this.
Firefox and Safari ignore
mediaonlink[rel="icon"]and take the first or second icon only, respectively.Another approach is to dynamically set the
hrefon the icon, but this only works consistently for Firefox and Chrome; Safari seems to have very aggressive caching which makes this difficult/impossible in a standard way.