Fix _is_unique to correctly handle boolean arrays - #430
Merged
Conversation
Fixes #429 where boolean segmentation masks were incorrectly identified as already labeled due to type coercion in np.array_equal(). This caused segmentation_to_objects() to skip labeling and pass boolean arrays directly to skimage.measure.regionprops(), resulting in a TypeError. The fix adds a dtype check to return False for boolean arrays before performing the array comparison. Changes: - Add dtype check in _is_unique() to return False for boolean arrays - Add unit tests for _is_unique() covering boolean, labeled, and unlabeled arrays 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429 where boolean segmentation masks were incorrectly identified as already labeled due to type coercion in np.array_equal(). This caused segmentation_to_objects() to skip labeling and pass boolean arrays directly to skimage.measure.regionprops(), resulting in a TypeError.
The fix adds a dtype check to return False for boolean arrays before performing the array comparison.
Changes:
🤖 Generated with Claude Code