fix: ghost chars in cmd2, column display. - #158
Merged
Conversation
* Fix issues in readline rendering. Navigating command history with arrow keys left remnant "ghost characters" on the prompt line. **Root cause:** The shell's `_rl()` helper manually wrapped ANSI escape codes in readline non-printing markers (`\x01`/`\x02`), but cmd2 already does this automatically via `rl_escape_prompt()`. The double-wrapping produced orphan `\x02` bytes that GNU readline counted as visible characters, inflating its prompt width calculation and causing incomplete redraws during history recall. **Fix:** Removed `_rl()` and all manual `\x01`/`\x02` wrapping from prompt construction. ANSI escape codes are now passed as raw sequences, letting cmd2 handle readline escaping. Reported history bugs are just due to terminal size. Assisted-by: claude fixes: quadsproject#154
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating command history with arrow keys left remnant "ghost characters" on the prompt line.
Root cause: The shell's
_rl()helper manually wrapped ANSI escape codes in readline non-printing markers (\x01/\x02), but cmd2 already does this automatically viarl_escape_prompt(). The double-wrapping produced orphan\x02bytes that GNU readline counted as visible characters, inflating its prompt width calculation and causing incomplete redraws during history recall.Fix: Removed
_rl()and all manual\x01/\x02wrapping from prompt construction. ANSI escape codes are now passed as raw sequences, letting cmd2 handle readline escaping.Reported history bugs are just due to terminal size.
Assisted-by: claude
fixes: #154