fix: create a separate gui using qt6 - #149
Closed
kambiz-aghaiepour wants to merge 16 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Have a meta package that installs "quads-client-gui" that pulls in "quads-client-gui-tk" by default. Use alternatives to ensure "quads-client-gui" uses the tk version. The user can optionally install "quads-client-gui-qc" Both can co-exist
Initial port was based on a slightly older version. Bring the qt into parity with the same features as tk
qt version
The call to self.host_filters.populate_metadata_async() was copied from the tkinter version which has its own metadata-loading method on HostFilterFrame, but the Qt6 HostFilterFrame doesn't expose that method. The VLAN and OS dropdowns are still populated asynchronously by the thread that calls get_available_vlans() and get_available_os() — the host filter widget loads its own model/NIC data internally when needed.
horizontal line separator was not touching the vertical line near the top
For both light and dark, give background and buttons a metallic finish. Button presses are 3d effect.
Contributor
|
Let's make this available as a separate branch and not change in any way the RPM spec or installation process/workflow with the python stdlib client/GUI. I would say we want a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updates creates two gui packages which cannot both be installed. They conflict with one another intentionally, so the user must choose if they want to install quads-client-gui-tk or quads-client-gui-qt6. Both "provide" quads-client-gui