Skip to content

feat: add --timeout argument for configurable REST call timeout - #540

Merged
sadsfae merged 1 commit into
quadsproject:developmentfrom
mmahut:mmahut/412
May 19, 2026
Merged

feat: add --timeout argument for configurable REST call timeout#540
sadsfae merged 1 commit into
quadsproject:developmentfrom
mmahut:mmahut/412

Conversation

@mmahut

@mmahut mmahut commented May 11, 2026

Copy link
Copy Markdown
Contributor

Adding --timeout for all the calls now, resolves #412.

Please note, previously, only GET had a hardcoded 60s timeout — POST, PATCH, and DELETE had no timeout and would hang indefinitely on an unresponsive BMC. With this change all four methods default to 60s. Long-running operations that previously ran without a clock may now hit the default. This is might or might not be an issue depending on your daily operations.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@mmahut
mmahut marked this pull request as ready for review May 11, 2026 21:24
@mmahut

mmahut commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@codecov wake up buddy.

@sadsfae
sadsfae changed the base branch from master to development May 16, 2026 20:22
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 93.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/badfish/config.py 100.00% <100.00%> (ø)
src/badfish/helpers/http_client.py 96.72% <100.00%> (+0.01%) ⬆️
src/badfish/helpers/parser.py 100.00% <100.00%> (ø)
src/badfish/main.py 92.68% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sadsfae
sadsfae merged commit 7ba509b into quadsproject:development May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Add --timeout argument

2 participants