feat: add --timeout argument for configurable REST call timeout - #540
Merged
Conversation
mmahut
marked this pull request as ready for review
May 11, 2026 21:24
Contributor
Author
|
@codecov wake up buddy. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding --timeout for all the calls now, resolves #412.
Please note, previously, only GET had a hardcoded 60s timeout — POST, PATCH, and DELETE had no timeout and would hang indefinitely on an unresponsive BMC. With this change all four methods default to 60s. Long-running operations that previously ran without a clock may now hit the default. This is might or might not be an issue depending on your daily operations.
All Submissions:
Changes to Core Features: