Update YMDK YMD75 rev3 to match rev4 - #26410
Open
sodevel wants to merge 8 commits into
Open
Conversation
Use RGB Light instead of RGB Matrix keycodes, add Backlight keycodes.
It is not recommended to use this feature anymore.
This seems to be rarely used.
This barely affects firmware size and is enabled for rev4 too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the rev3 to match the improvements i made for the rev4 in #26204. Additionally, it enables NKRO (i don't know why it was disabled), Backlight Breathing (so the setting in VIA does finally do something) and sets Bootmagic to really use the ESC key.
I removed the GBP £ Macro from the default keymap, both revisions now use almost the same keymap, rev3 has some extra keycodes to control the backlight.
I own PCBs of both revisions and can confirm the changes do work for me.
Types of Changes
Issues Fixed or Closed by This PR
Checklist