Fix update of userspace config when running qmk userspace-add interactively - #26403
Open
zvecr wants to merge 1 commit into
Open
Fix update of userspace config when running qmk userspace-add interactively#26403zvecr wants to merge 1 commit into
qmk userspace-add interactively#26403zvecr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if you run
qmk userspace-addwith no arguments, it will prompt the user for various inputs. In this case, the keyboard/keymap arguments are not known byuserspace_add.The userspace config is updated within the
new_keymapcall without the potentialcli.args.envvalue. Another attempt to save then happens as part ofuserspace_addwith its own view of the current state, but as the keyboard/keymap args are empty the entry is then missing.This PR refactors the cli logic into something that is callable with args, instead of the population of a
cliobject. It also updates the logic so that a save only happens once, and with the correct keyboard/keymap arguments regardless of if they originated from command line or prompt.Types of Changes
Issues Fixed or Closed by This PR
Checklist