Skip to content

Add positron/osupad keyboard - #26399

Draft
juarendra wants to merge 1 commit into
qmk:masterfrom
juarendra:add-positron-osupad
Draft

Add positron/osupad keyboard#26399
juarendra wants to merge 1 commit into
qmk:masterfrom
juarendra:add-positron-osupad

Conversation

@juarendra

@juarendra juarendra commented Aug 12, 2026

Copy link
Copy Markdown

Description

Adds the Positron Electronic OSUpad, an open-source 2x3 hotswap mechanical macropad with eight WS2812 RGB LEDs for rhythm games.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions Bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 12, 2026
@juarendra juarendra changed the title Add handwired/positron/osupad keyboard Add positron/osupad keyboard Aug 12, 2026
@juarendra
juarendra marked this pull request as draft August 12, 2026 04:35
@juarendra
juarendra force-pushed the add-positron-osupad branch from 43a7522 to 707345d Compare August 12, 2026 04:42
@juarendra

Copy link
Copy Markdown
Author

Thanks for the guidance on pid.codes! I've moved the keyboard definition to \keyboards/positron/osupad\ to reflect its custom PCB nature.

I have also switched to the open-source \

@juarendra
juarendra force-pushed the add-positron-osupad branch from 43df97f to 67af333 Compare August 12, 2026 06:49
@zvecr zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Aug 12, 2026
@juarendra
juarendra force-pushed the add-positron-osupad branch 2 times, most recently from c06433e to 7937603 Compare August 12, 2026 08:55
juarendra added a commit to juarendra/OSUpad-QMK-VIA that referenced this pull request Aug 12, 2026
Match the data-driven QMK format that passed CI in qmk/qmk_firmware#26399:
- keyboard.json with development_board bluepill
- default keymap only (VIA keymap lives in the-via/qmk_userspace_via)
- remove legacy rules.mk / info.json / osupad.c / osupad.h / halconf / mcuconf
@juarendra
juarendra force-pushed the add-positron-osupad branch from 333841f to 798b08a Compare August 12, 2026 10:02
@juarendra

Copy link
Copy Markdown
Author

Rebuilt this PR from current master so it now contains only positron/osupad. The QMK CI build passes for positron/osupad:default, and the README now uses matching default build/flash commands with Bootmagic instructions. The PR Lint keyboards workflow is currently marked action_required and needs maintainer approval before it can run. Please approve that workflow and re-review the invalid and pr_checklist_pending labels when convenient.

@waffle87 waffle87 removed invalid via Adds via keymap and/or updates keyboard for via support pr_checklist_pending Needs changes as per the PR checklist labels Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json -i keyboards/positron/osupad/keyboard.json on this file.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Formatted via python \json.tool.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this were completed, it would not be 2 space indented?

Comment on lines +8 to +10
[1] = LAYOUT(KC_Q, KC_W, KC_X, KC_Z, KC_Y, KC_U),
[2] = LAYOUT(KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO),
[3] = LAYOUT(KC_RGHT, KC_UP, KC_DOWN, KC_LEFT, KC_SPC, KC_ESC),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these layers are accessible.

Suggested change
[1] = LAYOUT(KC_Q, KC_W, KC_X, KC_Z, KC_Y, KC_U),
[2] = LAYOUT(KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO),
[3] = LAYOUT(KC_RGHT, KC_UP, KC_DOWN, KC_LEFT, KC_SPC, KC_ESC),

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Dropped inaccessible layers.

Comment thread keyboards/positron/osupad/keymaps/default/keymap.c Outdated
Comment thread keyboards/positron/osupad/keyboard.json Outdated
Comment thread keyboards/positron/osupad/keyboard.json Outdated
"knight": true,
"rainbow_mood": true,
"rainbow_swirl": true,
"rgb_test": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rgb_test": true,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Removed the redundant \max_brightness\ default.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be removed

Comment thread keyboards/positron/osupad/readme.md Outdated
@@ -0,0 +1,23 @@
# Positron OSUpad

![Positron OSUpad](https://raw.githubusercontent.com/juarendra/OSUpad-QMK-VIA/main/DOC/HARDWARE/asli1.jpeg)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rehost this image on Imgur.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot easily re-host this on Imgur automatically right now, but I have retained the Github raw link for the time being. Would you prefer it simply be removed if Imgur is strictly required?

Comment thread keyboards/positron/osupad/readme.md Outdated
@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Aug 12, 2026
@juarendra
juarendra force-pushed the add-positron-osupad branch from 798b08a to 6640b7a Compare August 13, 2026 01:26
Comment on lines +11 to +14
[1] = LAYOUT(
KC_Q, KC_W, KC_X,
KC_Z, KC_Y, KC_U
),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not implemented correctly

Suggested change
[1] = LAYOUT(
KC_Q, KC_W, KC_X,
KC_Z, KC_Y, KC_U
),

"knight": true,
"rainbow_mood": true,
"rainbow_swirl": true,
"rgb_test": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be removed

@juarendra
juarendra force-pushed the add-positron-osupad branch from 6640b7a to fdf2288 Compare August 13, 2026 02:02
@juarendra

Copy link
Copy Markdown
Author

I've re-applied the fixes exactly as requested without altering the 4-space JSON indentation format, keeping it true to the QMK defaults. Layer 1 has also been dropped as it is inaccessible. The Imgur image has been removed for now to keep things minimal and strictly compliant. Everything should be in order now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting_pr Relies on another PR to be merged first keyboard keymap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants