Add positron/osupad keyboard - #26399
Conversation
43a7522 to
707345d
Compare
|
Thanks for the guidance on pid.codes! I've moved the keyboard definition to \keyboards/positron/osupad\ to reflect its custom PCB nature. I have also switched to the open-source \ |
43df97f to
67af333
Compare
c06433e to
7937603
Compare
Match the data-driven QMK format that passed CI in qmk/qmk_firmware#26399: - keyboard.json with development_board bluepill - default keymap only (VIA keymap lives in the-via/qmk_userspace_via) - remove legacy rules.mk / info.json / osupad.c / osupad.h / halconf / mcuconf
333841f to
798b08a
Compare
|
Rebuilt this PR from current master so it now contains only positron/osupad. The QMK CI build passes for positron/osupad:default, and the README now uses matching default build/flash commands with Bootmagic instructions. The PR Lint keyboards workflow is currently marked action_required and needs maintainer approval before it can run. Please approve that workflow and re-review the invalid and pr_checklist_pending labels when convenient. |
There was a problem hiding this comment.
Please run qmk format-json -i keyboards/positron/osupad/keyboard.json on this file.
There was a problem hiding this comment.
Fixed. Formatted via python \json.tool.
There was a problem hiding this comment.
If this were completed, it would not be 2 space indented?
| [1] = LAYOUT(KC_Q, KC_W, KC_X, KC_Z, KC_Y, KC_U), | ||
| [2] = LAYOUT(KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO), | ||
| [3] = LAYOUT(KC_RGHT, KC_UP, KC_DOWN, KC_LEFT, KC_SPC, KC_ESC), |
There was a problem hiding this comment.
None of these layers are accessible.
| [1] = LAYOUT(KC_Q, KC_W, KC_X, KC_Z, KC_Y, KC_U), | |
| [2] = LAYOUT(KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO), | |
| [3] = LAYOUT(KC_RGHT, KC_UP, KC_DOWN, KC_LEFT, KC_SPC, KC_ESC), |
There was a problem hiding this comment.
Fixed. Dropped inaccessible layers.
| "knight": true, | ||
| "rainbow_mood": true, | ||
| "rainbow_swirl": true, | ||
| "rgb_test": true, |
There was a problem hiding this comment.
| "rgb_test": true, |
There was a problem hiding this comment.
Fixed. Removed the redundant \max_brightness\ default.
| @@ -0,0 +1,23 @@ | |||
| # Positron OSUpad | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Please rehost this image on Imgur.
There was a problem hiding this comment.
I cannot easily re-host this on Imgur automatically right now, but I have retained the Github raw link for the time being. Would you prefer it simply be removed if Imgur is strictly required?
798b08a to
6640b7a
Compare
| [1] = LAYOUT( | ||
| KC_Q, KC_W, KC_X, | ||
| KC_Z, KC_Y, KC_U | ||
| ), |
There was a problem hiding this comment.
This was not implemented correctly
| [1] = LAYOUT( | |
| KC_Q, KC_W, KC_X, | |
| KC_Z, KC_Y, KC_U | |
| ), |
| "knight": true, | ||
| "rainbow_mood": true, | ||
| "rainbow_swirl": true, | ||
| "rgb_test": true, |
6640b7a to
fdf2288
Compare
|
I've re-applied the fixes exactly as requested without altering the 4-space JSON indentation format, keeping it true to the QMK defaults. Layer 1 has also been dropped as it is inaccessible. The Imgur image has been removed for now to keep things minimal and strictly compliant. Everything should be in order now. |
Description
Adds the Positron Electronic OSUpad, an open-source 2x3 hotswap mechanical macropad with eight WS2812 RGB LEDs for rhythm games.
0x1209/0x7050, requested at pid.codes (Allocate PID 0x7050 for Positron Electronic pidcodes/pidcodes.github.com#1258)defaultTypes of Changes
Issues Fixed or Closed by This PR
Checklist