Feature/Enhancement: Allow Default Keymaps per Layout Macro#591
Draft
noroadsleft wants to merge 6 commits into
Draft
Feature/Enhancement: Allow Default Keymaps per Layout Macro#591noroadsleft wants to merge 6 commits into
noroadsleft wants to merge 6 commits into
Conversation
Changes expected path from: public/keymaps/<keyboard>_default.json to: public/keymaps/<keyboard_path>/<layout_macro>.json
Collaborator
|
While I admire the ambition I'm not thrilled with the implementation. I kind of wish you'd discussed this in an open forum rather than doing what is a remarkable amount of work. In general I don't think this is a scaleable or verifiable approach What I would have preferred is one file per keyboard. Each file contains multiple entries. It would be no worse than what we have today but would allow us to automate verification using tooling. Let's talk offline about some alternative approaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restructures the default keymap system such that each layout macro on the keyboard can have a default keymap, independent of the other layouts that can be used by the hardware.
Pros
Cons
Things I'd Like to Have for This Feature...
... but probably don't know how to achieve yet:
LAYOUT_all,LAYOUTandKEYMAPmacros listed first, then the rest in alphabetical orderpublic/keymaps/_generic/Review / Discuss Please