[develop] Fix: UWP→WinUI namespace and reference replacements#13
Open
[develop] Fix: UWP→WinUI namespace and reference replacements#13
Conversation
Owner
Author
Review Result: APPROVEDThis PR implements a large-scale mechanical replacement of UWP API reference links (/uwp/api/Windows.UI.Xaml.) with WinUI 3 paths (/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.) across 38 modified files. The namespace and API link replacements are technically correct. WinUI 3 paths correctly map Windows.UI.Xaml.* to microsoft.ui.xaml.*. Additional code quality fixes (removal of deprecated ListViewItemRevealStyle, update of obsolete SystemControlAccentAcrylicWindowAccentMediumHighBrush) are also appropriate. Must-Fix IssuesNone. Suggestions (non-blocking)
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
qiutongMS
force-pushed
the
fix/develop/uwp-to-winui-namespace-and-reference-replacements
branch
from
27b2cf3 to
51a4876
Compare
Owner
Author
Review Result: CHANGES_REQUESTEDSummaryThis PR performs a mechanical UWP→WinUI namespace replacement across 30 files. Most changes are correct, but 3 must-fix issues were found: two broken links (404s) introduced by the replacement, and link display texts that still show old UWP namespace qualifiers while targeting WinUI 3 API pages. Must-Fix Issues
Suggestions
Page Health Assessment
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
Review Result: CHANGES_REQUESTEDSummaryThe PR correctly migrates most Windows.UI.Xaml namespace references to Microsoft.UI.Xaml with proper Windows App SDK link prefixes. However, one change introduces a broken link (404) in navigationview.md: the TypeName API URL was migrated to a path that does not exist in the Windows App SDK docs. Must-Fix Issues
Suggestions
Page Health Assessment
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
Review Result: CHANGES_REQUESTEDSummaryThe PR correctly migrates 65 namespace/link references across 30 files from UWP ( Must-Fix Issues
Suggestions
Page Health Assessment
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
Review Result: APPROVEDSummaryAll 30 files contain technically correct WinUI 3 migrations: Must-Fix IssuesNone. Suggestions
Page Health AssessmentAll 30 modified files read well. Notable highlights:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical replacement of 65 UWP namespace references and API links across 45 pages. All changes follow the same pattern: Windows.UI.Xaml → Microsoft.UI.Xaml and /uwp/api/ → /windows/windows-app-sdk/api/winrt/.