Skip to content

[develop] Fix: Small fix corrections across multiple pages (2)#12

Open
qiutongMS wants to merge 2 commits intodocsfrom
fix/develop/small-fix-corrections-across-multiple-pages-2
Open

[develop] Fix: Small fix corrections across multiple pages (2)#12
qiutongMS wants to merge 2 commits intodocsfrom
fix/develop/small-fix-corrections-across-multiple-pages-2

Conversation

@qiutongMS
Copy link
Copy Markdown
Owner

Summary

  • fix small documentation corrections across 10 develop pages
  • correct API/type names, code snippets, and WinUI/Windows App SDK reference links
  • align code samples with surrounding prose and fix loop/event handler issues

Validation

  • git diff --cached --ignore-cr-at-eol --check
  • validated updated Microsoft Learn links with HTTP HEAD requests (all returned 200)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qiutongMS
Copy link
Copy Markdown
Owner Author

Summary: The PR fixes several small documentation issues, but I found a few remaining correctness problems in two modified pages that should be addressed before merge.

Must-fix issues:

  1. hub/apps/windows-app-sdk/migrate-to-windows-app-sdk/guides/windowing.md — In the compact overlay section, the prose still says AppWindowPresenterKind.RequestPresentation. RequestPresentation is a method on AppWindowPresenter, not on AppWindowPresenterKind.
  2. hub/apps/windows-app-sdk/migrate-to-windows-app-sdk/guides/windowing.md — In the full-screen mapping table, the UWP AppWindow column still says AppWindowPresenterKind.FullScreen; the UWP enum is AppWindowPresentationKind.FullScreen.
  3. hub/apps/develop/ui/layout-panels.md — In the Canvas section, Canvas.Left still links to the WPF /dotnet/api/system.windows.controls.canvas.left page while the surrounding content was updated to Windows App SDK links. That leaves readers on the wrong framework reference page.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qiutongMS
Copy link
Copy Markdown
Owner Author

Summary: I reviewed the diff and the full modified pages. The changes correct API names, code samples, loop/event syntax, and reference links without introducing new technical or structural issues.

Must-fix issues: None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant