Skip to content

[develop] Fix: Small fix corrections across multiple pages (3)#11

Open
qiutongMS wants to merge 1 commit intodocsfrom
fix/develop/small-fix-corrections-across-multiple-pages-3
Open

[develop] Fix: Small fix corrections across multiple pages (3)#11
qiutongMS wants to merge 1 commit intodocsfrom
fix/develop/small-fix-corrections-across-multiple-pages-3

Conversation

@qiutongMS
Copy link
Copy Markdown
Owner

Summary

  • fix small documentation/code-sample issues across 10 develop pages
  • correct code snippets for dialogs, dependency properties, Cosmos DB, navigation, passkeys, and other sample issues
  • clean up smart card prerequisites and a malformed code block

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qiutongMS
Copy link
Copy Markdown
Owner Author

Review Result: APPROVED

Summary

All 10 changes are technically correct and improve documentation quality. Fixes include a logic bug (rowcount vs colcount), a JavaScript class-name error (Uint8Array), a C# lambda syntax error, a missing
eturn false\ statement, correct API usage patterns, and important modifier additions (\public static readonly\ on DependencyProperty). No must-fix issues were identified.

Must-Fix Issues

None.

Suggestions

# File Line/Section Suggestion Severity
1 hub/apps/develop/security/use-cases.md navigator.credentials.get code block After fixing \UInt8Array → Uint8Array, the \id\ field indentation dropped to 5 spaces while \ ype\ stays at 6 spaces in the same object literal — minor inconsistency worth aligning suggestion
2 hub/apps/develop/security/smart-cards.md "Create a virtual smart card" section Prerequisite was demoted from a >[!NOTE]\ callout to plain prose; consider using > [!IMPORTANT]\ or > [!NOTE]\ to preserve reader visibility suggestion
3 hub/apps/develop/ui/controls/rich-edit-box.md SaveButton_Click handler New \ContentDialog\ (like the existing open-error dialog) omits the \XamlRoot\ property assignment required by WinUI 3 — both dialogs would throw at runtime; pre-existing issue, but worth a follow-up fix for both handlers suggestion

Page Health Assessment

File Overall Quality Notes
hub/apps/design/layout/boxpanel-example-custom-panel.md ✅ Good Logic bug (rowcount vs colcount) correctly fixed
hub/apps/develop/composition/source-modifiers.md ✅ Good Plain prose inside code block correctly converted to C# comment
hub/apps/develop/data-access/cosmos-db-data-access.md ✅ Good Explicit ContainerResponse two-step pattern is clearer for learners
hub/apps/develop/security/share-certificates.md ✅ Good Grammar fix and missing \
eturn false\ both correct
hub/apps/develop/security/smart-cards.md ✅ Good Stray }\ correctly removed; prerequisite repositioned logically before steps
hub/apps/develop/security/use-cases.md ✅ Good Missing opening quote and wrong JS class name (UInt8Array→Uint8Array) both fixed
hub/apps/develop/security/windows-hello-auth-service.md ✅ Good Lambda operator syntax error (\ = >\ → \ =>) correctly fixed
hub/apps/develop/ui/controls/rich-edit-box.md ✅ Good MessageDialog correctly replaced with ContentDialog (WinUI 3 pattern)
hub/apps/develop/ui/navigation/navigate-between-two-pages.md ✅ Good Class name corrected from MainPage to Page2 for the back-navigation handler
hub/apps/winui/winui3/xaml-templated-controls-winui-3.md ✅ Good \public static readonly\ modifiers are required for DependencyProperty — important correctness fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant