fix(qauld-ctl): line editing, quoted args, account crash & help in shell - #901
Open
dastansam wants to merge 1 commit into
Open
fix(qauld-ctl): line editing, quoted args, account crash & help in shell#901dastansam wants to merge 1 commit into
dastansam wants to merge 1 commit into
Conversation
dastansam
force-pushed
the
fix/qauld-ctl-shell
branch
from
July 5, 2026 12:46
baa033f to
a466e66
Compare
Fixes a batch of `qauld-ctl shell` issues: - Line editing via rustyline: arrow up/down recall command history (also persisted to ~/.qauld-ctl_history), arrow left/right move the cursor to edit the current line. Replaces the canonical-mode line reader; async events now print through rustyline's ExternalPrinter so they don't corrupt the line being edited. - Quoted arguments with spaces work now, e.g. `feed send -m "hello my friend"`: the line is tokenised with shell-style quoting (shlex) instead of split_whitespace. - `account login/logout/status` no longer crash. They hit a `todo!()` in encode_request that panicked the whole process (taking the shell down with it); they now delegate to the auth flow — login runs the challenge-response, logout/status return a graceful error — matching the `auth` command. - `help` prints the real command list (rendered clap help) instead of a vague pointer, and the same help screen is shown on shell startup. Verified end-to-end through a pty: history recall, cursor-edit, a quoted message round-tripped through a live daemon, and the account subcommands (graceful, no panic). Adds a regression test for the account crash.
dastansam
force-pushed
the
fix/qauld-ctl-shell
branch
from
July 6, 2026 13:59
a466e66 to
0a14e6e
Compare
|
dastansam
marked this pull request as ready for review
July 28, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a batch of
qauld-ctl shellissues:feed send -m "hello my friend": the line is tokenised with shell-style quoting (shlex) instead of split_whitespace.account login/logout/statusno longer crash. They hit atodo!()in encode_request that panicked the whole process (taking the shell down with it); they now delegate to the auth flow — login runs the challenge-response, logout/status return a graceful error — matching theauthcommand.helpprints the real command list (rendered clap help) instead of a vague pointer, and the same help screen is shown on shell startup.Verified end-to-end through a pty: history recall, cursor-edit, a quoted message round-tripped through a live daemon, and the account subcommands (graceful, no panic). Adds a regression test for the account crash.
closes #898