[WIP][SimpleFSDP] add manual bucketing pass #1881
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for aten-level manual bucketing in SimpleFSDP+
aot_eager
backend. Dependent on PyTorch PRTODO List:
manual_bucketed_modules
. It would be very easy to miss some of model modules. (cc. @xmfan @SherlockNoMad )aot_eager
backend)Llama 3-8B
Example SimpleFSDP 1D overlapping trace:
FSDP-only:

FSDP+TP:
DeepSeekV3-16B