-
Notifications
You must be signed in to change notification settings - Fork 571
fix imports in components/checkpoint.py #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @saforem2! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In torchtitan, we assume PyTorch version is nightly. You can follow the README to download the last est PyTorch nightly.
|
ahhhh, okay. I saw from the README
but didn't know it was a strict requirement. The only reason I bring it up is because I'm currently testing on Intel XPU devices, but our production (user-facing) environments are currently at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried rebasing onto latest pytorch nightly?
I was seeing:
ModuleNotFoundErrorincomponents/checkpoint.py:ImportErrorissue intorchtitan/distributed/pipeline_parallel.py:PyTorch Config:
Copilot Summary
This pull request introduces several updates to the checkpointing and pipeline parallel scheduling logic to improve compatibility, simplify configuration, and streamline checkpoint saving. The most significant changes involve refactoring how checkpoint staging and consolidation are handled, updating the pipeline schedule import logic for better fallback, and removing obsolete or redundant configuration options.
Checkpointing improvements and refactoring:
DefaultStagerandStagingOptionsincheckpoint.pyto use a fallback implementation if the primary import fails, improving compatibility across different PyTorch versions. (torchtitan/components/checkpoint.py)HuggingFaceStorageWriterby removing conditional consolidation and always enabling consolidation with a fixed thread count, streamlining the checkpoint saving process. (torchtitan/components/checkpoint.py)consolidate_safetensors_files_on_every_rankafter saving, as consolidation is now always handled during the save operation itself. (torchtitan/components/checkpoint.py)load_onlyoption and all related checks, as well as redundant state management for staging, to simplify the checkpointing interface and behavior. (torchtitan/components/checkpoint.py) [1] [2] [3] [4]Pipeline parallel scheduling updates:
ScheduleDualPipeVto provide a fallback toScheduleZBVZeroBubbleif the primary schedule is unavailable, increasing robustness to upstream changes. (torchtitan/distributed/pipeline_parallel.py)torchtitan/distributed/pipeline_parallel.py)